edit: patch .values warning in time_series.ipynb #1576
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaehyunAhn
requested review from
lamberta,
MarkDaoust and
yashk2810
as code owners
JaehyunAhn
changed the title
JaehyunAhn
changed the title
|
Thanks for the PR. This entire notebook got rewritten. If this is still a problem please remake the PR from the master branch. Sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edited time_series.ipynb. In some recent stable Pandas versions, warning occurs when trying to call
.valuesmethod with pandas.core.series.Series object. In this reason, edited.valuesmethod to.to_numpy()method to makepandas.core.series.Seriesobject to convertnumpy.ndarrayobject, which pandas official documents recommended (https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.DataFrame.values.html). There is a rationale behind (pandas-dev/pandas#19954). Another way that convert pandas.core.series.Series object with index to numpy.ndarray object is call.arraymethod, which works similar with.to_numpy(). In that case, Series object convert intopandas.core.arrays.numpy_.PandasArrayobject.