Enhancement 284 Sealed Trait #366
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please run |
y21
reviewed
Jul 20, 2022
| mod private { | ||
| pub trait Sealed {} | ||
|
|
||
| impl <T> Sealed for T{} |
There was a problem hiding this comment.
I don't think this blanket impl makes sense, because it implements Sealed for all types, even for types defined in other crates. That makes the TensorType: private::Sealed bound useless, because it's implemented for every type already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds generic
Sealedsuper trait and applies it toTensorType.Fixes #284