Remove the dependency on the internal rules_webtesting util #6771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…recent `rules_webtesting`
yatbear
changed the title
platform_http_file
arcra
reviewed
Feb 29, 2024
| # if archive is a dmg then convert it to a zip | ||
| if basename.endswith(".dmg"): | ||
| zipfile = basename.replace(".dmg", ".zip") | ||
| repository_ctx.execute([repository_ctx.path(Label("//web/internal:convert_dmg.sh")), basename, zipfile]) |
There was a problem hiding this comment.
Is this script something that needs to be copied to our repo as well? (and this path updated, perhaps?)
There was a problem hiding this comment.
As discussed offline, we will try alternative approaches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a prerequisite for #6770.
The
platfrom_http_fileutil is copied from https://github.com/bazelbuild/rules_webtesting/releases/tag/0.3.0. This was an internal method inrules_webtestingand has been removed in their recent releases.#oncall