Fix regex dialog 'Save' text color #6774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcra
approved these changes
Mar 5, 2024
AnuarTB
pushed a commit
to AnuarTB/tensorboard
that referenced
this pull request
May 3, 2024
The regex dialog "Save" button is rendered poorly internaly, dark text on dark background. The color of the button text was changed to 'inherit' in go/tbpr/6631. It doesn't seem to have been necessary so I revert that particular change here. It means in OSS TensorBoard the button text color will be slightly darker than previously. I didn't personally notice the difference but internal screenshot tests show a slight difference. Googlers, see cr/612557079.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex dialog "Save" button is rendered poorly internaly, dark text on dark background.
The color of the button text was changed to 'inherit' in go/tbpr/6631. It doesn't seem to have been necessary so I revert that particular change here.
It means in OSS TensorBoard the button text color will be slightly darker than previously. I didn't personally notice the difference but internal screenshot tests show a slight difference. Googlers, see cr/612557079.