Repository navigation
Conversation
…in permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
nsextonTT
marked this pull request as ready for review
November 11, 2026 03:57
nsextonTT
requested review from
a team,
acvejicTT,
bgoelTT,
idjuricTT,
mdobrosavljevicTT,
mjeremicTT,
vcankovicTT and
vmaksimovicTT
as code owners
November 11, 2026 03:57
fivanovicTT
reviewed
Nov 11, 2026
| types: | ||
| - completed | ||
|
|
||
| permissions: {} |
Collaborator
There was a problem hiding this comment.
This workflow passes github.token through GH_TOKEN to the external collect_data action. Its download script uses that token to fetch workflow data and download report artifacts with gh run download.
permissions: {} removes the token’s Actions permission, but artifact downloads require Actions read access. Runs containing report artifacts will therefore encounter authorization failures and lose the inputs needed to generate benchmark reports. The SFTP secrets authorize uploading the finished reports; they do not authorize downloading data from GitHub.
Could we grant actions: read here, or keep the empty root permissions block and grant it on produce-cicd-data? The minimal replacement is:
Suggested change
| permissions: {} | |
| permissions: | |
| actions: read |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/tenstorrent/tt-inference-server/security/code-scanning/14
Add an explicit
permissionsblock at the workflow root so all jobs in this workflow inherit least-privilege defaults.Best minimal safe change (without assuming write needs) is:
permissions: {}This sets all token permissions to
noneunless explicitly granted later. In this workflow, there are no checkout/upload/comment steps shown, and the step primarily uses secrets and inputs, so this is the strictest compliant fix for the current snippet. If later a job needs specific scopes, add only those scopes at job level.Edit
.github/workflows/produce_data.ymlby insertingpermissions: {}between theon:trigger block andjobs:.Suggested fixes powered by Copilot Autofix. Review carefully before merging.