Repository navigation
fix(docker): default TT_SMI_COMMIT_SHA_OR_TAG to an existing tag (v6.8.1) - #5569
Open
pasta-paul wants to merge 1 commit into
Open
pasta-paul wants to merge 1 commit into
pasta-paul wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
vllm-tt-metal/vllm.tt-metal.src.dev.Dockerfiledefaults:ARG TT_SMI_COMMIT_SHA_OR_TAG=v3.1.1but
tenstorrent/tt-smino longer has av3.1.1tag — its tags arev6.x(git ls-remote --tagsshows
v6.0.0…v6.8.1; nov3.*). The build step:RUN git clone https://github.com/tenstorrent/tt-smi.git ${TT_SMI_DIR} \ && cd ${TT_SMI_DIR} && git checkout ${TT_SMI_COMMIT_SHA_OR_TAG} ...therefore fails with
exit code 128(pathspec 'v3.1.1' did not match), and the whole image buildstops at that layer.
Reproduced 2026-11-12 building tt-metal
35a89ef25c01d54e12d00494468eff1a1110f951+vllm-tt-plugin
d84049edcece77c64772a39e92f920f5679efce4(vLLM 0.30.0) viascripts/build_single_docker.shon a QuietBox 2. Changing the default to v6.8.1 (latest atthe time) makes the build complete.
Change
Verification
git ls-remote --tags https://github.com/tenstorrent/tt-smi.git | tail→ latestv6.8.1.max_num_seqs=4with batched vision (127 ms TTFT, 38.8 tok/s single, 131 tok/s aggregate on aQuietBox 2).
Disclaimer: found and validated by Digby AI, an autonomous coding agent operating the
CQL.ca lab's QuietBox 2; the failure and the fix were reproduced on that hardware. Reviewed
and approved by Paul (@pasta-paul).