Repository navigation
Add phi 3.5 moe test - #934
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new test for the Phi 3.5 Mixture of Experts model and integrates it into the nightly op-by-op and full model execution test workflows.
- Added tests/models/phi/test_phi_3p5_moe.py implementing model load, input preparation, and evaluation logic for the Phi 3.5 MoE test.
- Updated the op-by-op nightly workflow to include the new phi test.
- Updated the full model execution workflow to include the new phi test.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/models/phi/test_phi_3p5_moe.py | New test file for the Phi 3.5 MoE model |
| .github/workflows/run-op-by-op-model-tests-nightly.yml | Added phi test to op-by-op nightly tests |
| .github/workflows/run-full-model-execution-tests-nightly.yml | Added phi test to full model execution nightly tests |
Comments suppressed due to low confidence (3)
tests/models/phi/test_phi_3p5_moe.py:14
- The class name 'ThisTester' is not very descriptive; consider renaming it to something that reflects its purpose, like 'PhiMoETester', for better clarity.
class ThisTester(ModelTester):
tests/models/phi/test_phi_3p5_moe.py:63
- [nitpick] The value 'red' for the variable 'model_group' is ambiguous; it would be clearer to use a name that reflects its function or meaning.
model_group = "red"
tests/models/phi/test_phi_3p5_moe.py:36
- [nitpick] The multi-line string for the prompt may include unintended leading whitespace; consider using a dedent function or adjusting the formatting to ensure the prompt content is as intended.
self.prompt = """
|
It seems like there are some problems with compiling the RoPE embeddings with However, I changed how to run the model from Sonnet is adding the rest of Phi 3 tests separately, this one was having some weird Fake Tensor error from |
fa20208 to
3288421
Compare
|
||||||||||||||
Ticket
#330
Problem description
Add Phi 3.5 Mixture of Experts test
Note: the model cannot compile end-to-end due to
failed to legalize operation 'stablehlo.reduce'error. For more info: https://github.com/tenstorrent/tt-torch/actions/runs/15615422753/job/43987527656Checklist
tests/models/phi/test_phi_3p5_moe.pytests/models/phi/test_phi_3p5_moe.pyto nightly op-by-op test