Skip to content

feat: Add lambda as additional auth provider #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 10, 2023
Merged

feat: Add lambda as additional auth provider #52

merged 1 commit into from
Aug 10, 2023

Conversation

jindrichskupa
Copy link
Contributor

Description

The change allows to use AWS_LAMBDA as additional auth provider. This block is missing in official AWS provider documentation here but the block is supported.

Motivation and Context

We use APIKEY as primary auth method and AWS_LAMBDA as additional.

Breaking Changes

No breaking changes.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested on my production terraform code to validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@jindrichskupa jindrichskupa changed the title feat(lambda-auth): add lambda as additional auth provider Add lambda as additional auth provider Aug 8, 2023
@jindrichskupa jindrichskupa changed the title Add lambda as additional auth provider feat(lambda-auth): Add lambda as additional auth provider Aug 8, 2023
@jindrichskupa
Copy link
Contributor Author

@antonbabenko Can you do the review, please?

antonbabenko
antonbabenko approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interestingly, it works well but I don't see this argument (lambda_authorizer_config) among documented arguments for additional_authentication_provider here - https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/appsync_graphql_api#additional_authentication_provider

Looks good, let me merge this.

@antonbabenko antonbabenko changed the title feat(lambda-auth): Add lambda as additional auth provider feat: Add lambda as additional auth provider Aug 10, 2023
@antonbabenko antonbabenko merged commit 9d641a4 into terraform-aws-modules:master Aug 10, 2023
antonbabenko pushed a commit that referenced this pull request Aug 10, 2023
@semantic-release-bot
chore(release): version 2.1.0 [skip ci]
50764f3 
## [2.1.0](v2.0.0...v2.1.0) (2023-08-10)

### Features

* Add lambda as additional auth provider ([#52](#52)) ([9d641a4](9d641a4))
@antonbabenko
Copy link
Member

This PR is included in version 2.1.0 🎉

@jindrichskupa
Copy link
Contributor Author

Cool, thanks.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 8, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@antonbabenko antonbabenko antonbabenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jindrichskupa @antonbabenko