Skip to content

fix: Fixed APPSYNC_JS resolvers for both kinds (UNIT and PIPELINE) #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 30, 2023
Merged

fix: Fixed APPSYNC_JS resolvers for both kinds (UNIT and PIPELINE) #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c8195f
fix 🐛 (appsync_resolver): fix bug preventing appsync_js resolvers for…
jagoodhand Aug 30, 2023
fd18f8c
fix 🐛 (appsync_resolver): remove request / response template defaults…
jagoodhand Aug 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions examples/complete/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,18 @@ EOF
]
}

"Query.singleComment" = {
kind = "UNIT"
type = "Query"
field = "singleComment"
code = file("src/function.js")
runtime = {
name = "APPSYNC_JS"
runtime_version = "1.0.0"
}
data_source = "dynamodb1"
}

"Query.user" = {
kind = "PIPELINE"
type = "Query"
Expand Down
6 changes: 6 additions & 0 deletions examples/complete/schema.graphql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,16 @@ type User {
name: String
}

type Comment {
id: ID !
comment: String!
}

type Query {
singlePost(id: ID!): Post
none(dummyString: String!): String!
user(id: ID!): User
singleComment(id: ID!): Comment
}

schema {
Expand Down
6 changes: 3 additions & 3 deletions main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,10 +201,10 @@ resource "aws_appsync_resolver" "this" {
}

# code is required when runtime is APPSYNC_JS
code = try(each.value.kind == "PIPELINE" && each.value.runtime.name == "APPSYNC_JS", false) ? each.value.code : null
code = try(each.value.runtime.name == "APPSYNC_JS", false) ? each.value.code : null

request_template = lookup(each.value, "request_template", tobool(lookup(each.value, "direct_lambda", false)) ? var.direct_lambda_request_template : try(each.value.kind == "PIPELINE" && each.value.runtime.name == "APPSYNC_JS", false) ? null : "{}")
response_template = lookup(each.value, "response_template", tobool(lookup(each.value, "direct_lambda", false)) ? var.direct_lambda_response_template : try(each.value.kind == "PIPELINE" && each.value.runtime.name == "APPSYNC_JS", false) ? null : "{}")
request_template = lookup(each.value, "request_template", tobool(lookup(each.value, "direct_lambda", false)) ? var.direct_lambda_request_template : try(each.value.runtime.name == "APPSYNC_JS", false) ? null : "{}")
response_template = lookup(each.value, "response_template", tobool(lookup(each.value, "direct_lambda", false)) ? var.direct_lambda_response_template : try(each.value.runtime.name == "APPSYNC_JS", false) ? null : "{}")

data_source = lookup(each.value, "data_source", null) != null ? aws_appsync_datasource.this[each.value.data_source].name : lookup(each.value, "data_source_arn", null)

Expand Down