docs: Update description of karpenter node_iam_role_use_name_prefix#3304
Merged
bryantbiggs merged 1 commit intoterraform-aws-modules:masterfrom Feb 19, 2025
Merged
docs: Update description of karpenter node_iam_role_use_name_prefix#3304bryantbiggs merged 1 commit intoterraform-aws-modules:masterfrom
node_iam_role_use_name_prefix#3304bryantbiggs merged 1 commit intoterraform-aws-modules:masterfrom
Conversation
ebachle
changed the title
node_iam_role_use_name_prefixnode_iam_role_use_name_prefix
bryantbiggs
approved these changes
Feb 18, 2025
It currently implies in the variable description that it will use the controller IAM role name (`iam_role_name`), but the code actually uses the `node_iam_role_name` for the prefix, if enabled.
Argote-Gustavo-bah
pushed a commit
to navwar-seastar/terraform-aws-eks
that referenced
this pull request
Feb 25, 2025
sarasensible
pushed a commit
to SensibleWeather/terraform-aws-eks
that referenced
this pull request
Feb 26, 2025
Member
|
This PR is included in version 20.34.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The karpenter submodule's variable
node_iam_role_use_name_prefixcurrently implies in the variable description that it will use the controller IAM role name (iam_role_name), but the code actually uses thenode_iam_role_namefor the prefix, if enabled.Motivation and Context
I believe this is a v19->v20 mistaken holder.
I didn't create an issue, but can if necessary.
Breaking Changes
Nope
How Has This Been Tested?
Docs only change.
pre-commit run -aon my pull request