Skip to content

feat!: Support multiple endpoint groups, add custom routing module, AWS provider MSV 5 #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

magreenbaum
Copy link
Member

@magreenbaum magreenbaum commented Jan 19, 2025

Description

Adds module for custom routing accelerators.
Adds support for multiple endpoint groups per listener.
Add standard accelerator endpoint_configuration.attachment_arn.
Adds ARN outputs.

Motivation and Context

Closes: #3

Breaking Changes

Yes. AWS Provider MSV 5 and support for multiple endpoint groups per listener.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@magreenbaum magreenbaum marked this pull request as ready for review January 20, 2025 13:34
Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bryantbiggs WDYT?

@bryantbiggs
Copy link
Member

Amazing, ship it!

@bryantbiggs bryantbiggs merged commit 4307cf2 into terraform-aws-modules:master Jan 24, 2025
8 checks passed
antonbabenko pushed a commit that referenced this pull request Jan 24, 2025
## [3.0.0](v2.2.2...v3.0.0) (2025-01-24)

### ⚠ BREAKING CHANGES

* Support multiple endpoint groups, add custom routing module, AWS provider MSV 5 (#16)

### Features

* Support multiple endpoint groups, add custom routing module, AWS provider MSV 5 ([#16](#16)) ([4307cf2](4307cf2))

### Bug Fixes

* Update CI workflow versions to latest ([#15](#15)) ([0443981](0443981))
@antonbabenko
Copy link
Member

This PR is included in version 3.0.0 🎉

@magreenbaum magreenbaum deleted the feat/custom_routing branch January 24, 2025 12:48
@magreenbaum
Copy link
Member Author

@antonbabenko looks like v3 didn't get published to the registry. Could you publish this when you have the chance please? 🙏

@antonbabenko
Copy link
Member

@magreenbaum I've just fixed it with the stick. :)

@bryantbiggs
Copy link
Member

image

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to add multiple endpoint_groups from different region in global-accelerator's listener
3 participants