feat: Enabled tags for IAM policies #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandeepgopi
changed the title
sandeepgopi
changed the title
|
Hi @antonbabenko . Hope you are doing well. Please can you review the above MR. This is to enable tags. It is to address the issue raised here #32 |
antonbabenko
changed the title
antonbabenko
requested changes
Apr 12, 2022
|
Hi @antonbabenko . Thank you for the update. It has been formatted. The changelog update was removed :) |
antonbabenko
pushed a commit
that referenced
this pull request
Apr 13, 2022
## [2.7.0](v2.6.0...v2.7.0) (2022-04-13) ### Features * Enabled tags for IAM policies ([#38](#38)) ([f9d3a89](f9d3a89))
|
This PR is included in version 2.7.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enablement of tags for:
The ''aws_iam_policy" resource with 'service' resource name
The ''aws_iam_policy" resource with 'additional_json' resource name
The ''aws_iam_policy" resource with 'additional_jsons' resource name
The ''aws_iam_policy" resource with 'additional_inline' resource name
The ''aws_iam_policy" resource with 'logs' resource name
Motivation and Context
When we began using the repo, we found that some of the resources are yet to be tag enabled. Hence when our internal projects were calling this repo, our custom tags were not being added in AWS.
Breaking Changes
No
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)