feat: Add optional policy_path variable used for policy definitions #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonbabenko
requested changes
Dec 1, 2023
variables.tf
Outdated
| variable "policy_path" { | ||
| description = "Path of IAM policies to use for Step Function" | ||
| type = string | ||
| default = "/" |
There was a problem hiding this comment.
Default to null is better. Please update.
There was a problem hiding this comment.
The default is updated to null.
… had completely omitted it if a value is null.
antonbabenko
reviewed
Dec 4, 2023
antonbabenko
approved these changes
Dec 4, 2023
|
Thank you, @rgrund-inform ! |
antonbabenko
pushed a commit
that referenced
this pull request
Dec 4, 2023
## [4.1.0](v4.0.1...v4.1.0) (2023-12-04) ### Features * Add optional policy_path variable used for policy definitions ([#60](#60)) ([cddcf93](cddcf93))
|
This PR is included in version 4.1.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add optional policy_path variable used for policy definitions.
Motivation and Context
If you are using policy_path for security reasons and need to set the policy_path, you will not be able to use the terraform-aws-step-functions. With this change, the path can be configured using the policy_path variable, or leave the default "/" if the variable is omitted.
Breaking Changes
No Breaking Changes the default for policy_path remains "/".
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)I have not updated the examples as
role_pathis also not used in the examples and I suspect that it was done that way on purpose.examples/*projectspre-commit run -aon my pull request