Skip to content

feat: Fix insides of the service block and typos #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 26, 2024
Merged

feat: Fix insides of the service block and typos #16

merged 6 commits into from
May 26, 2024

Conversation

delaskoff
Copy link
Contributor

@delaskoff delaskoff commented May 22, 2024 •
edited
Loading

what

  • Service block insides are being referenced from the right place
  • Some typos fixed
  • Features parameter support introduced
  • App-wide alert policy support introduced

why

  • Service parameters description is not in the right place
  • IDE highlighting of typos does the job right
  • Features parameter is missing
  • App-wide alert policies are missing

@delaskoff delaskoff force-pushed the master branch 3 times, most recently from c2b9271 to 63554b3 Compare May 22, 2024 16:55
delaskoff added 3 commits May 24, 2024 02:10
@delaskoff
Correct typos and punctuation
29560f4 
Signed-off-by: Yurii Liaskovets <[email protected]>
@delaskoff
Add missing features parameter
bc18654 
Signed-off-by: Yurii Liaskovets <[email protected]>
@delaskoff
Add missing alert policy parameter
c2a4b2e 
Signed-off-by: Yurii Liaskovets <[email protected]>
@clouddrove-ci clouddrove-ci merged commit 7cf3f49 into terraform-do-modules:master May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@delaskoff @clouddrove-ci