Add outputs for Kubernetes cluster token and CA certificate, fix auto_scale #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed by k8s and helm tf provider inputs
sepulworld
changed the title
anmolnagpal
approved these changes
Feb 6, 2025
clouddrove-ci
approved these changes
Feb 6, 2025
clouddrove-ci
merged commit 67be6c2
into
terraform-do-modules:master
14 of 15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Add outputs for Kubernetes cluster token and CA certificate. Fix auto_scale issue where node_count isn't needed if auto_scale is set.
why
These outputs can be used as inputs to the k8s and helm terraform providers directly
If trying to use auto_scale and node pool has scaled away from the node_count, terraform will set node pool back to node_count which we don't want.