Enabling management of default Dialogflow resources without terraform import: is_default_x fields#589
Merged
modular-magician merged 1 commit intoterraform-google-modules:masterfrom Nov 3, 2023
Conversation
… import: `is_default_x` fields (#9336) * Enabling management of Default Start Flow + Default Welcome Intent + Default Negative Intent, without terraform import Fixes hashicorp/terraform-provider-google#16308 * Basic tests for default flow + intents * Tests asserting resource IDs * Making Flow + Intent import respect is_default_X; fixing description on examples * Bah, making isFallback output-only might break users that'd imported the Default Negative Intent :( * Update mmv1/templates/terraform/pre_create/dialogflowcx_set_location_skip_default_obj.go.erb Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com> * Adding callout notes about multiple is_default_x resources * More words around the pre-create + pre-delete code * Adding more tests around Default Start Flow * Adding more tests around Default Welcome Intent and Default Negative Intent --------- Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com> [upstream:58d0735cfa46a3668a0c5af3181ce6443ab22d91] Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician
deleted the
downstream-pr-58d0735cfa46a3668a0c5af3181ce6443ab22d91
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes hashicorp/terraform-provider-google#16308, read that bug for more context 😅
An alternative version of GoogleCloudPlatform/magic-modules#9359 because designing a good API is hard and I want someone else to make that decision 😅.
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#9336