Skip to content

Conversation

@drwpow
Copy link
Collaborator

@drwpow drwpow commented Jan 19, 2025

Changes

Fixes #422, #423, #424. Rebuilds aliasing system to be even more correct and faster.

Resolves a slew of issues and inconsistent output.

How to Review

  • Tests updated; tests should pass

@drwpow drwpow force-pushed the plugin-css-improvements branch from 0daeda7 to 8fe6dff Compare January 19, 2025 07:29
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 19, 2025

Deploying terrazzo with  Cloudflare Pages  Cloudflare Pages

Latest commit: eae58bf
Status: ✅  Deploy successful!
Preview URL: https://54868aab.terrazzo.pages.dev
Branch Preview URL: https://plugin-css-improvements.terrazzo.pages.dev

View logs

@changeset-bot
Copy link

changeset-bot bot commented Jan 19, 2025

🦋 Changeset detected

Latest commit: eae58bf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@terrazzo/token-tools Minor
@terrazzo/parser Minor
@terrazzo/cli Minor
@terrazzo/plugin-sass Major
@terrazzo/plugin-css Major
@terrazzo/plugin-js Major
@terrazzo/plugin-swift Major
@terrazzo/plugin-tailwind Major
@terrazzo/token-lab Patch
@terrazzo/use-color Patch
@terrazzo/react-color-picker Patch
@terrazzo/tiles Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@drwpow drwpow force-pushed the plugin-css-improvements branch 8 times, most recently from 02caffe to 7d488cd Compare January 19, 2025 18:27
@drwpow drwpow force-pushed the plugin-css-improvements branch from 7d488cd to 74a2c21 Compare January 19, 2025 20:27
@drwpow drwpow force-pushed the plugin-css-improvements branch 6 times, most recently from 4c49c26 to 147cc2c Compare January 21, 2025 02:26
@drwpow drwpow force-pushed the plugin-css-improvements branch from 147cc2c to 7e3dda8 Compare January 21, 2025 02:26
@drwpow drwpow force-pushed the plugin-css-improvements branch from d1c712a to 3149b4c Compare January 21, 2025 03:51
@drwpow drwpow force-pushed the plugin-css-improvements branch from b4b89e7 to b7daea2 Compare January 21, 2025 04:44
@drwpow drwpow force-pushed the plugin-css-improvements branch from 410be08 to 17fd51a Compare January 21, 2025 04:49
@drwpow drwpow force-pushed the plugin-css-improvements branch from 66b72cd to 16fbc41 Compare January 21, 2025 04:51
const { id } = parseAlias(alias);
if (!tokens[id]) {
logger.error({ group: 'parser', label: 'alias', message: `Alias "${alias}" not found.`, filename, src, node });
export default function applyAliases(token: TokenNormalized, options: ApplyAliasOptions): void {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This rewrite made me want to pull my hair out. But here I am, (most) hairs in tact

@drwpow drwpow force-pushed the plugin-css-improvements branch from 16fbc41 to eae58bf Compare January 21, 2025 04:54
@drwpow drwpow merged commit 9a98ab0 into main Jan 21, 2025
9 checks passed
@drwpow drwpow deleted the plugin-css-improvements branch January 21, 2025 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

plugin-css: Shadow tokens drop legacyHex setting

2 participants