fix: Preserve originally-authored color when downsampling #468
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #464. Preserves originally-authored colorspace when downsampling to sRGB, etc.
This was never intentional behavior, merely a side effect of Culori’s
toGamut()API which converts to the lowest-common-denominator color space to ensure it’s valid in that space.Technically when converting back, we introduce the very very very tiny possibility a rounding error occurred. But since we’re using Culori, the “lossiness” of such color operations should always be so infinitesimally small, any rounding error shouldn’t have any impact in even the most extreme scenarios._
How to Review