Skip to content

Conversation

@dzonatan
Copy link
Contributor

Lets to specify the selector where CSS variables are defined.

Fixes #473

@changeset-bot
Copy link

changeset-bot bot commented May 13, 2025

🦋 Changeset detected

Latest commit: 556aa3a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@terrazzo/plugin-css Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dzonatan dzonatan force-pushed the feat/base-selector branch from 222a278 to 005295b Compare May 13, 2025 09:21
@dzonatan
Copy link
Contributor Author

should I take care of the changeset as well?

@drwpow
Copy link
Collaborator

drwpow commented May 13, 2025

This looks amazing! Great tests, no notes 🙂. And yes! Please follow the comment instructions and add a patch changeset (while it’s 0.x, patch is for non-breaking feature/bugfix, even though it’s a feature it’s backwards-compatible)

@drwpow drwpow self-requested a review May 13, 2025 17:10
lets to specify the selector where CSS variables are defined
@dzonatan dzonatan force-pushed the feat/base-selector branch from 005295b to 556aa3a Compare May 13, 2025 18:07
@dzonatan
Copy link
Contributor Author

Got it. Interesting approach with these changesets, I was only familiar with those conventional commits.
Force-pushed in case you prefer to still have a clean git log.

Copy link
Collaborator

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, thank you! We’ll release this later today.

@drwpow drwpow merged commit 0e24810 into terrazzoapp:main May 14, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

:host selector support for css plugin

2 participants