Skip to content

Conversation

@drwpow
Copy link
Collaborator

@drwpow drwpow commented Jul 2, 2025

Changes

Fixes #500, where HSL and HWB colors are declared 0 - 100, rather than 0 - 1.

Also removes the HSV colorspace, since that’s not part of CSS Color Module 4.

OKHSV is kept, only as a convenience.

How to Review

  • Tests added for all colorSpaces
  • Tests should pass

@changeset-bot
Copy link

changeset-bot bot commented Jul 2, 2025

🦋 Changeset detected

Latest commit: ff10c68

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@terrazzo/token-tools Minor
@terrazzo/parser Minor
@terrazzo/cli Minor
@terrazzo/plugin-css Major
@terrazzo/plugin-js Major
@terrazzo/plugin-sass Major
@terrazzo/plugin-tailwind Major
@terrazzo/plugin-vanilla-extract Major
@terrazzo/plugin-swift Major
@terrazzo/use-color Patch
@terrazzo/react-color-picker Patch
@terrazzo/tiles Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 2, 2025

Deploying terrazzo with  Cloudflare Pages  Cloudflare Pages

Latest commit: ff10c68
Status: ✅  Deploy successful!
Preview URL: https://bf5b28f8.terrazzo.pages.dev
Branch Preview URL: https://drwpow-fix-hsl.terrazzo.pages.dev

View logs

hsl: {
ranges: [
[0.0, 360.0],
[0.0, 100.0],
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ranges here may be a little overkill. But I wanted to avoid having this hardcoded somewhere that’d be easy to miss elsewhere.

@drwpow drwpow merged commit 0060100 into main Jul 2, 2025
8 checks passed
@drwpow drwpow deleted the drwpow/fix-hsl branch July 2, 2025 04:39
@github-actions github-actions bot mentioned this pull request Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

terrazzo cli fails to recognize components for hsl colorSpace

2 participants