teslamate-close-charge: syntax error near unexpected token `newline'

[brianmay]

Is there an existing issue for this?

• I have checked the existing issues and discussions, and I can confirm that there are no duplicates.

What happened?

[root@iot2:~]# teslamate-close-charge
/run/current-system/sw/bin/teslamate-close-charge: line 3: 1: Please provide a charge ID to close

[root@iot2:~]# teslamate-close-charge 2790
/run/agenix/teslamate: line 1: syntax error near unexpected token `newline'

[root@iot2:~]# bash teslamate-close-charge 2790
/run/agenix/teslamate: line 1: syntax error near unexpected token `newline'

To me it looks like the shell doesn't like my secrets, and wants the values to be quoted.

But the same file is also read by the systemd service file, and pretty sure environment variables cannot be quoted or you get the quotes included in the value.

Yuck.

I think this file needs to be parsed, and we cannot really use "source" to do it.

I notice my db password has a greater then symbol suspect this is the problem:

DATABASE_PASS=xyzxyz>

(This isn't my password)

Expected Behavior

No errors.

Can the issue reliably be reproduced?

Yes

Steps To Reproduce the issue

No response

Relevant log output

N/A

Screenshots

No response

Additional data

No response

Type of installation

NixOS (https://docs.teslamate.org/docs/installation/nixos)

Version

mcu2-upgraded-cars

PostgreSQL version

No response

Are you running latest major supported PostgreSQL version?

• I run the latest major supported PostgreSQL version

Are you using a reverse Proxy for TeslaMate?

Yes (specify in next field)

Details about your reverse Proxy if applicable

nginx

[brianmay]

OK, I was wrong, systemd does allow quoting values. https://www.freedesktop.org/software/systemd/man/latest/systemd.exec.html#EnvironmentFile=

But fact remains that the format is different, not suitable for sourcing.

I asked gpt, it offered different solutions, here is the simplest (not tested):

while IFS='=' read -r key value; do
    [[ -z "$key" || "$key" =~ ^# ]] && continue
    value="${value%\"}"   # strip trailing quote
    value="${value#\"}"   # strip leading quote
    [...]
done < "$ENV_FILE"

This isn't perfect - probably doesn't handle all cases - gpt suggested it could give a more precise answer, but may be "good enough".

[JakobLichterfeld]

OK, I was wrong, systemd does allow quoting values.

Yeah, I had the same issue with my RELEASE_COOKIE and quoting wit '' helped.