Skip to content

Conversation

@jameskitt616
Copy link
Contributor

@jameskitt616 jameskitt616 commented Nov 15, 2024

Add Detailed Energy Use to Drive Details to fix #4375.
image

@swiffer ping

@netlify
Copy link

netlify bot commented Nov 15, 2024

Deploy Preview for teslamate ready!

Name Link
🔨 Latest commit 59973f7
🔍 Latest deploy log https://app.netlify.com/sites/teslamate/deploys/673b776a3da2270008fbed8b
😎 Deploy Preview https://deploy-preview-4386--teslamate.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@swiffer
Copy link
Collaborator

swiffer commented Nov 16, 2024

Thanks for opening this PR - I do prefer getting #4367 in first.

This PR seems to be based on Grafana build bundled with TeslaMate v1.31.1, exports should be done on top of the latest master to avoid overwriting other changes / reduce noise from changed Grafana schema version.

To the added stats - as numbers are not fully matching and 10.6 kwh & 12.4 kwh are both referred to as "used" I would prefer changing that to Energy recovered and stop showing energy used before regenerative breaking. As the metric is new I've added a small explanation as well.

grafik

Commit that can be used after #4367 has been merged: 1b21cbb - feel free to use it for updating your PR if you agree.

@jameskitt616
Copy link
Contributor Author

I copied your Updated file into the PR now.

@cschanzle
Copy link

cschanzle commented Nov 18, 2024

Please use "braking" instead of "breaking".

@JakobLichterfeld
Copy link
Member

I do prefer getting #4367 in first.

#4367 is merged

@swiffer
Copy link
Collaborator

swiffer commented Nov 18, 2024

@jameskitt616 - could you reset this branch to lastest master and include commit f71c965

(already including the change from "breaking" to "braking").

@jameskitt616
Copy link
Contributor Author

Resolved the conflicts

@swiffer
Copy link
Collaborator

swiffer commented Nov 18, 2024

Thank you, would have been better to do a rebase instead to keep commits history clean but i think @JakobLichterfeld will do a squash merge anyhow.

@JakobLichterfeld
Copy link
Member

but i think @JakobLichterfeld will do a squash merge anyhow.

In most cases yes. In #4367 it was by mistake.

@swiffer
Copy link
Collaborator

swiffer commented Nov 19, 2024

ready for merge with squash

Copy link
Member

@JakobLichterfeld JakobLichterfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, performance: instant on slow hw

@JakobLichterfeld JakobLichterfeld changed the title Add Detailed Energy Use to drive-details.json feat: add Detailed Energy Use to drive-details Nov 19, 2024
@JakobLichterfeld JakobLichterfeld merged commit 6740b1a into teslamate-org:master Nov 19, 2024
15 checks passed
@jameskitt616 jameskitt616 deleted the patch-1 branch November 19, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dashboard Related to a Grafana dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Add total kWh Used/ recovered due to regenerative braking to drive details

4 participants