-
Notifications
You must be signed in to change notification settings - Fork 882
feat: add Detailed Energy Use to drive-details #4386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for teslamate ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Thanks for opening this PR - I do prefer getting #4367 in first. This PR seems to be based on Grafana build bundled with TeslaMate v1.31.1, exports should be done on top of the latest master to avoid overwriting other changes / reduce noise from changed Grafana schema version. To the added stats - as numbers are not fully matching and 10.6 kwh & 12.4 kwh are both referred to as "used" I would prefer changing that to Energy recovered and stop showing energy used before regenerative breaking. As the metric is new I've added a small explanation as well. Commit that can be used after #4367 has been merged: 1b21cbb - feel free to use it for updating your PR if you agree. |
|
I copied your Updated file into the PR now. |
|
Please use "braking" instead of "breaking". |
|
@jameskitt616 - could you reset this branch to lastest master and include commit f71c965 (already including the change from "breaking" to "braking"). |
|
Resolved the conflicts |
|
Thank you, would have been better to do a rebase instead to keep commits history clean but i think @JakobLichterfeld will do a squash merge anyhow. |
In most cases yes. In #4367 it was by mistake. |
|
ready for merge with squash |
JakobLichterfeld
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, performance: instant on slow hw

Add Detailed Energy Use to Drive Details to fix #4375.

@swiffer ping