Skip to content

Conversation

@swiffer
Copy link
Collaborator

@swiffer swiffer commented Apr 8, 2025

fixes #4642

@netlify
Copy link

netlify bot commented Apr 8, 2025

Deploy Preview for teslamate ready!

Name Link
🔨 Latest commit ec86ea4
🔍 Latest deploy log https://app.netlify.com/sites/teslamate/deploys/67f56e53012e5800089b445b
😎 Deploy Preview https://deploy-preview-4644--teslamate.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JakobLichterfeld JakobLichterfeld changed the title fix: improve calc for usable (now) fix: improve calc for usable (now) in battery health dashboard Apr 9, 2025
@JakobLichterfeld JakobLichterfeld added the area:dashboard Related to a Grafana dashboard label Apr 9, 2025
@swiffer
Copy link
Collaborator Author

swiffer commented Apr 10, 2025

@JakobLichterfeld - lgtm, should improve in situations reported in #4642

Copy link
Member

@JakobLichterfeld JakobLichterfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Ty!
As our test images are currently only generated for branches in TeslaMate repo, it would be awesome if you can open new PR with branches in our repo.

@JakobLichterfeld JakobLichterfeld merged commit 76b8479 into teslamate-org:master Apr 10, 2025
11 of 15 checks passed
@swiffer
Copy link
Collaborator Author

swiffer commented Apr 10, 2025

My permissions seem to not allow that. I can neither comment on locked issues nor push to this repo as far as i know. Or do i need to change something locally?

@JakobLichterfeld
Copy link
Member

My permissions seem to not allow that. I can neither comment on locked issues nor push to this repo as far as i know. Or do i need to change something locally?

Oh indeed, I added you with write role in TeslaMate repo just now (you have “only” been in the org)

@JakobLichterfeld
Copy link
Member

I will fix the CI hopefully in the next weeks

@swiffer swiffer deleted the fix-improve-battery-health-useable-now branch April 11, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dashboard Related to a Grafana dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Usable (now) wrong

2 participants