fix: set $__timezone explicitly in dashboards to ensure truncation is done with respect to the Grafana timezone

[swiffer]

Grafana is not setting the PostgreSQL session timezone. To ensure truncation is done with respect to the Grafana timezone setting set the optional time_zone argument for DATE_TRUNC().

Fixes #4675

[netlify]

✅ Deploy Preview for teslamate ready!

Name	Link
🔨 Latest commit	62c0c2a
🔍 Latest deploy log	https://app.netlify.com/sites/teslamate/deploys/68075fedd88aeb0007e8d6d0
😎 Deploy Preview	https://deploy-preview-4684--teslamate.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[JakobLichterfeld]

Thanks!
Unfortunately there seems to be some syntax error in Drive Stats

v1.33.0 as comparison:

[swiffer]

on it

[JakobLichterfeld]

Number of drives is different as well

[swiffer]

yes, drives happening over night have been missing so far - current number should be correct. can you compare with drives dashboard?

[JakobLichterfeld]

Syntax Error is fixed, ty!

yes, drives happening over night have been missing so far - current number should be correct. can you compare with drives dashboard?

Nope, drives dashboard shows 122 rows for last 6 months which seems to be right

v1.33.0 drive stats dashboard shows same number but #4684 does show 137

No overnight drives as of my knowledge

[swiffer]

Okay, will have a look...

[DrMichael]

Let's collect it here...
#4675 (comment)
Almost there... :-)
You still need to replace in the Statistics' dashboard the CASE $period's the date by TIMEZONE('$__timezone', date).
Currently, the period shows up correctly in my edge case, but the period is the day before...

Charging Stats for my edge case looks good. I don't have drives between 00:00 and 01:00...

Perhaps @giterdone509 can also test it. He is 4 hours off UTC...

[swiffer]

@JakobLichterfeld do you have any incomplete drives? drives dashboard and stat are identical looking at my data 🤔

[JakobLichterfeld]

@JakobLichterfeld do you have any incomplete drives? drives dashboard and stat are identical looking at my data 🤔

Yeah but not in this timeframe as of my knowledge, that's why I choose the 6 month period
Edit: 15 incomplete drives on 2024-11-04, so in the period, my fault.

[swiffer]

ok, should those be ex or included?

[swiffer]

@DrMichael - thanks checking this! fixed all places where making use of to_char!

[DrMichael]

@DrMichael - thanks checking this! fixed all places where making use of to_char!

My pleasure. Thanks for your work...

[JakobLichterfeld]

ok, should those be ex or included?

A drive is a drive, innit? So in my case it is one drive which was split in 15 due to whatever reason.
So as a user I would expect unclosed drives to be included.
Or we write number of finished drives

[swiffer]

Ready to be merged

[JakobLichterfeld]

ok, should those be ex or included?

A drive is a drive, innit? So in my case it is one drive which was split in 15 due to whatever reason.
So as a user I would expect unclosed drives to be included.
Or we write number of finished drives

Sorry, during my run in the woods I changed my mind. We do handle unclosed drives and charges as corrupt in other places, aren't we? So they should not be included and you are right.

[swiffer]

ok, done ;)

[JakobLichterfeld]

Successfully tested. Ty!
And sorry for the back and forth