fix(nix): skip duplicate cldr download to fix build on darwin and improve reproducibility

[JakobLichterfeld]

fixes: #4761

[netlify]

✅ Deploy Preview for teslamate ready!

Name	Link
🔨 Latest commit	ac73bab
🔍 Latest deploy log	https://app.netlify.com/projects/teslamate/deploys/683810c69ca83f000835c928
😎 Deploy Preview	https://deploy-preview-4763--teslamate.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[JakobLichterfeld]

Setting the env variable like this does not solve the issue, as it is too late in mixRelease

[JakobLichterfeld]

Not sure if we should explicitly set it, as we use the package module in our devenv as well, innit?

[brianmay]

The devenv environment won't be used during package builds.

[brianmay]

Am I bit unclear, is this still not working?

Anyway, docs have:

  # if using mix2nix you can use the mixNixDeps attribute
  mixFodDeps = packages.fetchMixDeps {
    pname = "mix-deps-${pname}";
    inherit src version;
    # nix will complain and tell you the right value to replace this with
    hash = lib.fakeHash;
    mixEnv = ""; # default is "prod", when empty includes all dependencies, such as "dev", "test".
    # if you have build time environment variables add them here
    MY_ENV_VAR = "my_value";
  };

I think this makes in clear that mixEnv="prod" is the default.

And not sure I entirely understand, but it suggests SKIP_LOCALE_DOWNLOAD should be set inside the fetchMixDeps block. If this was still not working, that might be the solution.

[JakobLichterfeld]

Am I bit unclear, is this still not working?

It's working, it needed to be "true"

[JakobLichterfeld]

And not sure I entirely understand, but it suggests SKIP_LOCALE_DOWNLOAD should be set inside the fetchMixDeps block

I just tested moving the Env Variable into the fetchMixDeps, but the build failed with a permission denied error. This PR resolves that issue.

[brianmay]

The only thing here I am not sure of is setting MIX_ENV explicitly to prod, I think mixEnv is the required setting, and it already defaults to prod anyway.

[JakobLichterfeld]

The only thing here I am not sure of is setting MIX_ENV explicitly to prod, I think mixEnv is the required setting, and it already defaults to prod anyway.

I agree, my bad, and I've removed it.