fix: align usage of time-range filters to fix consumption gross issues in some edge cases #4787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for teslamate ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
JakobLichterfeld
changed the title
JakobLichterfeld
approved these changes
Jun 9, 2025
Member
JakobLichterfeld
left a comment
JakobLichterfeld
left a comment
There was a problem hiding this comment.
lgtm. Thanks so much!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aligns usage of filters used in consumption gross queries with other panels to avoid some edge cases.
as all other queries are using date filters on start_date of a drive let's ensure we are doing the same for queries relying on positions / advanced logic.
before this change - selecting a period with a start date at the time of driving (actual drive start out of selected period) consumption gross was off.
after this change - numbers to align correctly