fix: correctly determine charging phases in charge detail dashboard #4988
Conversation
✅ Deploy Preview for teslamate ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
JakobLichterfeld
changed the title
JakobLichterfeld
changed the title
…fix-phases-in-grafana-dashboard
|
@JakobLichterfeld - do you know if it's possible that number of phases change within a charging process? as in contrast to teslamate's elixir code we want to visualize data over time i might need to rethink this a little (the way it's solved now phases are constant within a charging process). |
From my understanding, it is not possible. You can change the charging current, but not the number of phases used. If the phases change, the charge is completed and a new charge starts. |
|
Ok, i guess in that case we can keep as is and fine-tune if any users notices data beeing off / comes up with a different example. |
…eslamate-org#4988) * mimic the elixir code to determine phases * docs: update changelog --------- Co-authored-by: Jakob Lichterfeld <[email protected]>
…eslamate-org#4988) * mimic the elixir code to determine phases * docs: update changelog --------- Co-authored-by: Jakob Lichterfeld <[email protected]>
|
Had to revert this one to fix errors with the Charge Details and Power panels on the dashboard |
|
@sdwalker could you elaborate whats broken for you / share charges and charging process data that is affected? |
|
Any DC supercharging (US only?) session is broken AC (split-phase) charging sessions are fine |
|
Same here - will come up with a fix tomorrow morning! |
this fixes #4987
the idea is to not "blindly" change phases (i actually charged with two phases lately) but use the same approach that is used in elixir for phase correction.
teslamate/lib/teslamate/log.ex
Line 533 in 0b11c41
the original case statement was added in #2527 and intended to fix #414