Fix and improve Windows installer #4348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
stweil
commented
Nov 6, 2024
stweil
commented
- Add missing DLLs which are provided by the compiler.
- Strip all executables. This reduces the size of the installer from about 44 MB to 25 MB.
- Some more small improvements.
Strip all installed executables and libraries. Signed-off-by: Stefan Weil <[email protected]>
The pattern for the training tools *.exe also includes tesseract.exe, so it must be excluded explicitly. Add also a macro BINDIR which simplifies the NSIS rules. Signed-off-by: Stefan Weil <[email protected]>
The Debian package mingw-w64-tools already contains the required /usr/bin/x86_64-w64-mingw32-pkg-config. Signed-off-by: Stefan Weil <[email protected]>
…nstaller The build process needs the packages curl, python3-venv and unzip which are missing in the Docker image for Ubuntu. Signed-off-by: Stefan Weil <[email protected]>
libstdc++-6.dll and libgcc_s_seh-1.dll must be taken from the compiler directory, not from the pacman DLLs. Signed-off-by: Stefan Weil <[email protected]>
egorpugin
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.