Skip to content

Kwok does not work with latest tag #419

@CryoCodec

Description

@CryoCodec

Describe the bug

Hi Folks,
thanks for the work you're doing!
I just played around with the kwok module and while it works just fine as is, it does not work with the latest tags, e.g. registry.k8s.io/kwok/cluster:v0.7.0-k8s.v1.33.0. The issue seems to be in the ready_conditions, which expects a specific message on std_out. In the mentioned tag, this message is no longer logged and the container never becomes ready.
I did not find a way, to override the ready_conditions. Am I missing something?

To Reproduce

 KwokCluster::default()
            .with_tag("v0.7.0-k8s.v1.33.0")
            .start()
            .await?;

Expected behavior

The container should become ready.
I see these options:

  • either we update the KWOK module to work with the later Kwok versions. When keeping the checks in place, the mentioned version logs "Cluster is started".
  • relax the ready conditions to not depend on the specific std_out message
  • or the user may override the ready_condition checks

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions