fix: use official secondary package format #300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this fixes the `@testing-library/angular/spec-utils` import in Jest v28 closes testing-library#299
There was a problem hiding this comment.
Hi, thanks for raising an issue and creating this PR.
If I remember correctly, we had to use this setup because otherwise it would cause issues for projects that aren't using Jest as their test runner.
Before I approve this, I want to make sure we don't break anything on that part.
|
@all-contributors please add @dzonatan for code |
|
I've put up a pull request to add @dzonatan! 🎉 |
|
🎉 This PR is included in version 12.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #299
changes made based on documentation:
https://angular.io/guide/angular-package-format#entrypoints-and-code-splitting
https://github.com/ng-packagr/ng-packagr/blob/main/docs/secondary-entrypoints.md
dist result:
