-
Notifications
You must be signed in to change notification settings - Fork 471
Make screen
query methods generic
#1033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
screen
query methods generic
I tried to solve this, but AFAIK there isn't a way to "automatically" add the generic to the queries of the screen object. I'll leave this open for someone that is able to add the generic "automatically". |
Let's start with this. We can always improve later though from my understanding, we can't carry generics over automatically. So the manual approach is probably going to stick for a while. |
🎉 This issue has been resolved in version 8.7.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
@testing-library/dom
version: 8.5.0Relevant code or config:
What you did:
Defined a type argument for
getByText
What happened:
Reproduction:
Problem description:
While the methods are generic, the way they're redefined on the
screen
object for example makes them lose their genericness.Original request: #615
PR which made the methods generic: #1023
Suggested solution:
The text was updated successfully, but these errors were encountered: