fix: handle ignores for ByText in suggestions #597
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 29cba89:
|
Codecov Report
@@ Coverage Diff @@
## master #597 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 24 24
Lines 535 536 +1
Branches 133 133
=========================================
+ Hits 535 536 +1
Continue to review full report at Codecov.
|
benmonro
force-pushed
the
bug/suggestion-fixes
branch
from
964af82 to
001179b
Compare
…-testing-library into bug/suggestion-fixes
src/suggestions.js
Outdated
| const textContent = normalize(element.textContent) | ||
| if (textContent) { | ||
| const textContent = normalize(getNodeText(element)) | ||
| if (textContent && !element.matches('script, style')) { |
There was a problem hiding this comment.
Can't we use the same ignores that are used by the query options? I think that would be best
|
Yep will do
|
| const textContent = normalize(element.textContent) | ||
| if (textContent) { | ||
| const textContent = normalize(getNodeText(element)) | ||
| if (textContent && !element.matches(DEFAULT_IGNORE_TAGS)) { |
There was a problem hiding this comment.
Sorry, I don't mean it should be the default ignore but rather whatever ignore configuration was passed to the query. Is that possible?
There was a problem hiding this comment.
Oh that's not necessary. The only reason it would be suggesting getByText is if it got something lower down the list and afaict none of those would use ignore. And the only 2 above byText are label and role neither of which have an ignore option
There was a problem hiding this comment.
And if you're already using text it won't suggest text again
|
sweet, thanks @kentcdodds now to publish which-query to the chrome store. :) |
|
🎉 This PR is included in version 7.7.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
What: properly handles
ignoreoption in suggestions.Why: previously if you try to get a suggestion on a random element it would not ignore script, style tags and suggest getByText on those elements.
How:
.matches("script, style")Checklist:
docs site
DefinitelyTyped