-
Notifications
You must be signed in to change notification settings - Fork 471
fix: update config type #598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c76c1b5:
|
Codecov Report
@@ Coverage Diff @@
## master #598 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 24 24
Lines 536 536
Branches 133 133
=========================================
Hits 536 536 Continue to review full report at Codecov.
|
Yes, these should be consistent. That was an oversight. I suggest we add the option and deprecate the old one. |
@timdeschryver @kentcdodds actually I think it's ok to keep the naming different between the config & the inline option. Actually I'm hoping to add a way to choose between doing a warn and a throw, but in either case you'd still want to turn it off for a specific query so I think it's fine to keep them slightly different. also thanks for putting this PR in, thought i got all the typings, but must have missed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this merged now and we can talk about naming conventions later.
🎉 This PR is included in version 7.7.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
What: We forgot to add the
throwSuggestions
option in the global configWhy: To have intellisense. In TS projects we also currently get an error while trying to do the following.
How:
Checklist:
docs site
DefinitelyTyped
Should we try to keep the naming consistent?
For the global config it's
throwSuggestions
, while the config on a query basis issuggest
.