Skip to content

chore: upgrade all deps and fix the build #817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 9, 2020
Merged

Conversation

kentcdodds
Copy link
Member

What: This updates all deps and adds @types/estree to avoid dedup issues

Why: The build was broken. More info: rollup/plugins#639

How: Update all deps and add @types/estree temporarily

Checklist:

  • Documentation added to the
    docs site N/A
  • Tests N/A
  • Typescript definitions updated N/A
  • Ready to be merged

"@testing-library/jest-dom": "^5.10.1",
"dtslint": "^3.6.12",
"@testing-library/jest-dom": "^5.11.5",
"@types/estree": "0.0.45",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is added temporarily to avoid the deduping issues. Can be removed when this is resolved: rollup/plugins#639

@@ -1,6 +1,7 @@
{
"extends": ["dtslint/dtslint.json"],
"rules": {
"no-redundant-jsdoc": false,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the latest version of dtslint, this fails on our @deprecated annotations.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 9, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 704170f:

Sandbox Source
react-testing-library-examples Configuration

@codecov
Copy link

codecov bot commented Nov 9, 2020

Codecov Report

Merging #817 (704170f) into master (3092c69) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #817   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines          911       910    -1     
  Branches       277       276    -1     
=========================================
- Hits           911       910    -1     
Impacted Files Coverage Δ
src/suggestions.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9917a3...704170f. Read the comment docs.

@kentcdodds
Copy link
Member Author

I think we want to disable push builds on anything but branches that can get released.

@kentcdodds kentcdodds merged commit 2fea70c into master Nov 9, 2020
@kentcdodds kentcdodds deleted the pr/fix-build branch November 9, 2020 20:50
@github-actions
Copy link

🎉 This PR is included in version 7.26.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant