Skip to content

docs: remove outdated pre-commit instructions #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

AriPerkkio
Copy link
Contributor

What:

Removes out-dated instructions about .opt-in file.

Why:

Support for .opt-in was droppped in [email protected]: kentcdodds/kcd-scripts#119.
This section should have been removed in #447.

How:
-

Checklist:

  • Documentation added to the N/A
    docs site
  • Tests N/A
  • Typescript definitions updated N/A
  • Ready to be merged

Ran into this issue when studying why pre-commit hooks of all testing-library repositories get stuck in my environment. This wasn't the root cause though - I'll keep debugging.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 7, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 32f3ca2:

Sandbox Source
react-testing-library-examples Configuration

@codecov
Copy link

codecov bot commented Mar 7, 2021

Codecov Report

Merging #909 (32f3ca2) into master (300bfe2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #909   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines          944       944           
  Branches       285       285           
=========================================
  Hits           944       944           
Flag Coverage Δ
node-10.14.2 100.00% <ø> (ø)
node-12 100.00% <ø> (ø)
node-14 100.00% <ø> (ø)
node-15 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 300bfe2...32f3ca2. Read the comment docs.

Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eps1lon eps1lon changed the title docs: remove out-dated pre-commit instructions docs: remove outdated pre-commit instructions Mar 7, 2021
@eps1lon eps1lon merged commit f6c5fee into testing-library:master Mar 7, 2021
@eps1lon
Copy link
Member

eps1lon commented Mar 7, 2021

@all-contributors add @AriPerkkio for docs

@allcontributors
Copy link
Contributor

@eps1lon

I've put up a pull request to add @AriPerkkio! 🎉

@AriPerkkio AriPerkkio deleted the docs/contributing-pre-commit branch March 7, 2021 12:14
@github-actions
Copy link

🎉 This PR is included in version 7.30.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants