fix: add prefer-in-document to recommended config

[nickserv]

What: add prefer-in-document to recommended config

Why: this is a useful rule that's in line with other best practices that the recommended config follows

How: enabled recommended flag

Checklist:

• Documentation
• Tests N/A
• Ready to be merged
  

[codecov]

Codecov Report

Merging #112 (e3eb694) into master (c397bd1) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #112   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          247       247           
  Branches        37        37           
=========================================
  Hits           247       247           

Impacted Files	Coverage Δ
src/rules/prefer-in-document.js	100.00% <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c397bd1...e3eb694. Read the comment docs.

[AntonNiklasson]

I agree it should be recommended. I'll leave it up to Ben to decide though.

[AriPerkkio]

@nickmccurdy before adding this rule as recommended check the latest added smoke tests, PR. prefer-in-document is crashing on many repositories. Here's one example:

Rule: prefer-in-document

• Message: Cannot read property 'name' of undefined Occurred while linting <text>:159
• Path: gatsbyjs/gatsby/integration-tests/structured-logging/__tests__/logs.js
• Link

        event.type === `LOG_ACTION` &&
        event.action.type === `ACTIVITY_END` &&
        event.action.payload.id === `createPages`
    )
    expect(createPagesEndActivityEvent).toBeDefined()
    expect(createPagesEndActivityEvent.action.payload.status).toBe(`FAILED`)
  })
  ;[`success`, `info`, `warn`, `log`, `error`].forEach(level => {
    // success, info and log all emit `INFO`
    const mapActionToLevel = {

TypeError: Cannot read property 'name' of undefined
Occurred while linting <text>:159
    at check (/<root-path-removed>/eslint-plugin-jest-dom/dist/rules/prefer-in-document.js:39:27)
    at CallExpression[callee.object.callee.name='expect'][callee.property.name=/(toHaveLength|toBeDefined|toBeNull)/] (/<root-path-removed>/eslint-plugin-jest-dom/dist/rules/prefer-in-document.js:97:7)
    at /<root-path-removed>/eslint-plugin-jest-dom/node_modules/eslint/lib/linter/safe-emitter.js:45:58
    at Array.forEach (<anonymous>)
    at Object.emit (/<root-path-removed>/eslint-plugin-jest-dom/node_modules/eslint/lib/linter/safe-emitter.js:45:38)
    at NodeEventGenerator.applySelector (/<root-path-removed>/eslint-plugin-jest-dom/node_modules/eslint/lib/linter/node-event-generator.js:254:26)
    at NodeEventGenerator.applySelectors (/<root-path-removed>/eslint-plugin-jest-dom/node_modules/eslint/lib/linter/node-event-generator.js:283:22)
    at NodeEventGenerator.enterNode (/<root-path-removed>/eslint-plugin-jest-dom/node_modules/eslint/lib/linter/node-event-generator.js:297:14)
    at CodePathAnalyzer.enterNode (/<root-path-removed>/eslint-plugin-jest-dom/node_modules/eslint/lib/linter/code-path-analysis/code-path-analyzer.js:711:23)
    at /<root-path-removed>/eslint-plugin-jest-dom/node_modules/eslint/lib/linter/linter.js:952:32

[benmonro]

let's hold off on merging this until #107 is implemented and we've had a chance to smoke test it more to make sure there's nothing crazy out there.

[benmonro]

all the smoke test issues have been resolved. changing to recommended. 👍

[github-actions]

🎉 This PR is included in version 3.4.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀