refactor node-utils type guards to use the AST_NODE_TYPES enum

[nonewcode]

This will migrate all of the hardcoded type guards to use the ENUM provided by @typescript-eslint/experimental-utils. There is also a couple of minor diffs to formatting after running npm run format and to fix some linting errors.

[Belco90]

Awesome, thanks for your first contribution!

[Belco90]

@all-contributors please add @codecog for code.

[allcontributors]

@Belco90

I've put up a pull request to add @codecog! 🎉

[gndelia]

hey @Belco90 what do you think about adding a ticket to check the stylings in Travis? I had hoped that those no styling issues would be caught on CI but I think we're not checking anything like that

[Belco90]

@gndelia you mean for running a "code validation" step in the CI before running the tests?

[nonewcode]

Ideally it would be more of a "precommit" step imo - formatting and linting issues should be addressed before CI runs.

[gndelia]

@gndelia you mean for running a "code validation" step in the CI before running the tests?

yes. Just checking the formatting + eslint are correct

Ideally it would be more of a "precommit" step imo - formatting and linting issues should be addressed before CI runs.

true, but that can be skipped (--no-verify), so we should still check it in the CI

btw thank you for your first PR 🎉

[Belco90]

Yeah, we already have the pre-commit hook enabled but has @gndelia pointed it can be skipped (could be wrongly setup too? I just checked the config and I have a slightly different one on other projects).

Running code validation in the CI will make sure everyone is applying the proper formatting/linting but without modifying anything.

I'm happy to have a task to add that, and check if the pre-commit is working fine.

[timdeschryver]

For me the pre-commit is working on (on windows).
But it can always be skipped (with --skipValidation), 👍 for CI.

[nonewcode]

The precommit didn’t work for me other than the commit message. Lint errors and formatting weren’t picked up.

…

On Mon, 3 Aug 2020 at 17:58, Tim Deschryver ***@***.***> wrote: For me the pre-commit is working on (on windows). But it can always be skipped (with --skipValidation), 👍 for CI. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#205 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABG6THEUAXPYRDVJSWSVUP3R63UCFANCNFSM4PTNJBVQ> .

[Belco90]

Per our setup it will format only those files modified (staged files). Bear that in mind.

[gndelia]

I opened #210

[Belco90]

🎉 This PR is included in version 3.4.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀