refactor(consistent-data-testid): use createTestingLibraryRule

[MichaelDeBoey]

I didn't add tests for the new skipRuleReportingCheck detection option (yet) as I don't know how to test that one.

@Belco90 could you point me in the right direction of how I would add tests for it?

---

This PR does some ground work for #358

[MichaelDeBoey]

I don't understand why GH is saying that detect-testing-library-utils.ts is a new file, as I only changed these parts and moved the file to the create-testing-library-rule folder

[Belco90]

I don't understand why GH is saying that detect-testing-library-utils.ts is a new file, as I only changed these parts and moved the file to the create-testing-library-rule folder

Could you avoid moving the file then? It's doing more harm than good, and we can move it in a different PR to avoid adding more noise here.

[Belco90]

@Belco90 could you point me in the right direction of how I would add tests for it?

Sure! All current consistent-data-testid tests must pass. You should duplicate some of the current cases, both valid and invalid ones, but switching Aggressive Reporting off through settings property, and the test result should be exactly the same as the original test case. This way you check that Aggressive Reporting and canReportErrors doesn't affect consistent-data-testid rule since it's passing the new skip option.

Let me know if you need more assistance over this!

edit: remove non-necessary explanation about how to implement the check itself

[github-actions]

🎉 This PR is included in version 4.2.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀