This repository was archived by the owner on Jul 30, 2020. It is now read-only.
fix(act): improve async act detection #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #50 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 20 20
Lines 262 262
Branches 65 65
=====================================
Hits 262 262Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #50 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 20 20
Lines 262 262
Branches 65 65
=====================================
Hits 262 262Continue to review full report at Codecov.
|
TAGraves
approved these changes
Aug 22, 2019
|
🎉 This PR is included in version 4.0.8 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Improve async act detection to achieve parity with RTL after testing-library/react-testing-library#407 and testing-library/react-testing-library#427 were merged.
Why:
This handles async act cases and detecting async act more effectively.
How:
This mostly just worked pulling it over from RTL. The only differences came because of using React Test Renderer instead of ReactDOM
act, and not rendering globally to a JSDOM document.Checklist:
docs site
Closes #47, closes #25