This repository was archived by the owner on Jul 30, 2020. It is now read-only.
Remove dependencies on Haste modules #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bcarroll22 Any thoughts on this approach? I tested this on both 0.59.6 and 0.61.0 RC, so it appears to be backwards compatible. |
|
Sorry for the delay, we can merge this to fix the issues for those on later versions if you've tested it on both. The checks still pass, so we're good to go. This doesn't seem like a breaking change, so we'll call it a bugfix, since it fixes compatibility with RN>0.60.0 |
bcarroll22
approved these changes
Sep 6, 2019
|
@allcontributors please add @jeffreyffs for code |
|
I've put up a pull request to add @jeffreyffs! 🎉 |
|
🎉 This PR is included in version 4.0.9 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Removes dependencies on haste modules
Why:
react-native 0.61.0 RC has been released and Haste modules no longer exist. Trying to find a module by its old Haste name (ie: 'View') no longer works.
How:
Changed from Haste module name -> path
Checklist:
docs site
I tested this against the current version of react-native in the package (0.59.6) and then I upgraded to react-native 0.61 and react 16.9.0 and all the tests also passed.
Also, I'm curious if anyone has a better way to do these mocks. Not in love with all the absolute paths in here.
Would love to get some additional 👀 and testing on this :)