This repository was archived by the owner on Jul 30, 2020. It is now read-only.
Fix matcher when values don't match types #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #62 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 20 20
Lines 266 266
Branches 67 67
=====================================
Hits 266 266
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 4.0.13 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: We added the ability to query by boolean for switches (as they have a value that is on/off). It broke a few things, mainly Switches being rendered alongside other components that get queried by displayValue (TextInput/Picker).
Why: We want to be able to test components that contain switches and TextInputs/Pickers
How: Don't try and normalize boolean values
Checklist:
docs site
Not 100% sure this is the correct way to go about this, but it works and passes the test cases I added that were breaking for me in my project.