This repository was archived by the owner on Jul 30, 2020. It is now read-only.
Fix - selector prop to filter queries #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
October 29, 2019 14:06
Codecov Report
@@ Coverage Diff @@
## master #76 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 20 20
Lines 268 268
Branches 67 67
=====================================
Hits 268 268
Continue to review full report at Codecov.
|
|
Awesome! Thanks for this! |
|
So, actually I just realized this is a breaking change. We'll be doing a major version bump here so folks in the current version can update at their own pace. So for anyone who comes across this, it'll be in the 5.0 release 👍 |
|
🎉 This PR is included in version 5.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Updated the implementation for queries to use the
selectorprop to filter resultsWhy:
The
selectorprop was incorrectly named in the implementation, does not reflect docs and the testing-library APIHow:
Updated named filter arguments to be selector
Checklist:
docs site
This resolves #71