-
Notifications
You must be signed in to change notification settings - Fork 1.1k
added waitForExpect #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
cef06a8
added waitForExpect with test
lgandecki e53d137
added typescript and simplified version of the waitForExpect, used an…
lgandecki 0a6bfaa
Merge branch 'master' of https://github.com/kentcdodds/react-testing-…
lgandecki dc7e692
added initial notes about waitForExpect
lgandecki 1f15dbc
fixed styling
lgandecki 91b241a
minor stylistic change
lgandecki 0c046ab
updated tests to remove the nesting
lgandecki 94faf4b
updated readme
lgandecki 32bbae3
fixed d .md syntax
lgandecki f4888bf
improved style
lgandecki File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,7 +24,9 @@ | |
"keywords": [], | ||
"author": "Kent C. Dodds <[email protected]> (http://kentcdodds.com/)", | ||
"license": "MIT", | ||
"dependencies": {}, | ||
"dependencies": { | ||
"wait-for-expect": "^0.1.0" | ||
}, | ||
"devDependencies": { | ||
"@types/react-dom": "^16.0.4", | ||
"axios": "^0.18.0", | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
import React from 'react' | ||
import {render, waitForExpect} from '../' | ||
|
||
const fetchAMessage = () => | ||
new Promise(resolve => { | ||
// we are using random timeout here to simulate a real-time example | ||
// of an async operation calling a callback at a non-deterministic time | ||
const randomTimeout = Math.floor(Math.random() * 100) | ||
setTimeout(() => { | ||
resolve({returnedMessage: 'Hello World'}) | ||
}, randomTimeout) | ||
}) | ||
|
||
class ComponentWithLoader extends React.Component { | ||
state = {loading: true} | ||
async componentDidMount() { | ||
const data = await fetchAMessage() | ||
this.setState({data, loading: false}) // eslint-disable-line | ||
} | ||
render() { | ||
if (this.state.loading) { | ||
return <div>Loading...</div> | ||
} else { | ||
return ( | ||
<div data-testid="message"> | ||
Loaded this message: {this.state.data.returnedMessage}! | ||
</div> | ||
) | ||
} | ||
} | ||
} | ||
|
||
test('it waits for the data to be loaded', async () => { | ||
const {queryByText, queryByTestId} = render(<ComponentWithLoader />) | ||
|
||
expect(queryByText('Loading...')).toBeTruthy() | ||
|
||
await waitForExpect(() => { | ||
expect(queryByText('Loading...')).toBeNull() | ||
expect(queryByTestId('message').textContent).toMatch(/Hello World/) | ||
}) | ||
}) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because we're going to discourage nesting assertions, could we move this assertion to after the waitForExpect?
This has the added benefit of not being waited for if it actually is broken. Maybe we should call that out actually.