Skip to content

docs: Add missing RenderOptions import #801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2021
Merged

docs: Add missing RenderOptions import #801

merged 1 commit into from
Apr 19, 2021

Conversation

AdriSolid
Copy link
Contributor

For #800

Background

Just adding a missing type RenderOptions in Setup/Custom Render for TypeScript example.

Change List

  • Modify docs/react-testing-library/setup.mdx TypeScript example adding RenderOptions type from @testing-library/react

@AdriSolid AdriSolid mentioned this pull request Apr 18, 2021
Closed
@eps1lon eps1lon linked an issue Apr 19, 2021 that may be closed by this pull request
type RenderOptions missed for TypeScript example in Setup/Custom Render #800
Closed
eps1lon
eps1lon approved these changes Apr 19, 2021
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eps1lon eps1lon changed the title fix: add RenderOptions type in react-testing-library/setup.mdx docs: Add missing RenderOptions import Apr 19, 2021
@eps1lon eps1lon merged commit 7dca457 into testing-library:master Apr 19, 2021
@eps1lon
Copy link
Member

eps1lon commented Apr 19, 2021

@all-contributors add @AdriSolid for docs

@allcontributors allcontributors bot mentioned this pull request Apr 19, 2021
Merged
@allcontributors
Copy link
Contributor

@eps1lon

I've put up a pull request to add @AdriSolid! 🎉

@AdriSolid AdriSolid deleted the adrisolid/add-renderoptions-type-setupmdx branch April 19, 2021 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon eps1lon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

type RenderOptions missed for TypeScript example in Setup/Custom Render
2 participants
@AdriSolid @eps1lon