Skip to content

chore: added missing package #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2021
Merged

chore: added missing package #823

merged 1 commit into from
May 5, 2021

Conversation

shemExelate
Copy link
Contributor

resolves #819

eps1lon
eps1lon approved these changes May 5, 2021
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Currently used in e.g.

testing-library-docs/src/components/GridBlock/index.jsx

Line 9 in 333fbd2

import classNames from 'classnames'

@eps1lon eps1lon merged commit c8616e3 into testing-library:master May 5, 2021
@eps1lon
Copy link
Member

eps1lon commented May 5, 2021

@all-contributors Add @shemExelate for code

@allcontributors allcontributors bot mentioned this pull request May 5, 2021
Merged
@allcontributors
Copy link
Contributor

@eps1lon

I've put up a pull request to add @shemExelate! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon eps1lon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

classnames package missing in dependencies
2 participants
@shemExelate @eps1lon