feat(devtools): add support for custom test-id attributes#227
Merged
feat(devtools): add support for custom test-id attributes#227
Conversation
Member
|
Thanks, @delca85! Awesome work. I'm going to merge it as is and will update the UI in a follow-up PR. |
smeijer
approved these changes
Jul 1, 2020
This was referenced Jul 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
I added a settings modal to chrome extension with the aim of setting a custom
testIdattribute to be used by queries in chrome extension.Why:
An issue was opened by a testing-playground user (#213).
How:
MenuBar.jscontaining an input that receives the custom testId by the userokbutton a message of typeSET_CUSTOM_TEST_IDis sent tocontentScriptcontent-scriptlaunch the newconfigurefunction onparserthat callsconfigureby testing-library setting the custom attribute as new test id attributeChecklist:
The modal is totally not styled, since the logic I developed is hopefully to be merged with the #226 by @smeijer .
I am linking a video to show how it works right now.