Skip to content

fix(devtools): escape newlines in logged queries #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2020
Merged

fix(devtools): escape newlines in logged queries #257

merged 1 commit into from
Jul 29, 2020

Conversation

smeijer
Copy link
Member

@smeijer smeijer commented Jul 29, 2020

What:
Escape queries before logging them to inspectedWindow

Why:
If we don't escape them, they won't be logged.

How:
Add slashes before single quotes and newlines.

Checklist:

  • Tests
  • Ready to be merged

@smeijer smeijer added the bug Something isn't working label Jul 29, 2020
@smeijer smeijer self-assigned this Jul 29, 2020
@smeijer smeijer merged commit a83f415 into develop Jul 29, 2020
@smeijer smeijer deleted the feature/escape-newlines branch July 29, 2020 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@smeijer smeijer

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@smeijer