Skip to content

Coveralls integration is broken #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
afontcu opened this issue Jun 30, 2019 · 4 comments
Closed

Coveralls integration is broken #51

afontcu opened this issue Jun 30, 2019 · 4 comments

Comments

@afontcu
Copy link
Member

afontcu commented Jun 30, 2019

I'mn assuming it has something to do with the relocation of the package under testing-library umbrella. Am I right @dfcook?

Is there anything I could do to fix it other than requesting coverall access to testing-library organization?

Thanks!
@dfcook
Copy link
Collaborator

dfcook commented Jul 30, 2019

It looks like testing-library uses codecov.io rather than coveralls, so it could be as simple as changing the url to:

https://codecov.io/github/testing-library/vue-testing-library

@afontcu
Copy link
Member Author

afontcu commented Jul 30, 2019

I just requested to install the Codecov app on VTL, we'll see how it goes :)

@dfcook
Copy link
Collaborator

dfcook commented Jul 30, 2019

I've enabled it, want to try a commit?

dfcook added a commit that referenced this issue Jul 31, 2019
@dfcook
#51 - update travis yaml for codecov
6c3a706
dfcook added a commit that referenced this issue Jul 31, 2019
@dfcook
Merge pull request #65 from testing-library/51-code-coverage
6eed2d8 
#51 code coverage
dfcook added a commit that referenced this issue Jul 31, 2019
@dfcook
#51 add coverage badge to readme
a67cbea
dfcook added a commit that referenced this issue Jul 31, 2019
@dfcook
Merge pull request #66 from testing-library/51-code-coverage
b24d5d2 
#51 add coverage badge to readme
@dfcook
Copy link
Collaborator

dfcook commented Jul 31, 2019

Updated to use codecov, also updated badge in readme

@dfcook dfcook closed this as completed Jul 31, 2019
@afontcu afontcu mentioned this issue Aug 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@afontcu @dfcook