compiler(amd64): return false on SSE4 unsupported CPUs

[evacchi]

I am not sure whether we should also add some test case to exercise this code path. Maybe enabling emulated tests as suggested in #581? Even my old Window laptop is newer and passes :D

Signed-off-by: Edoardo Vacchi [email protected]

Fixes #580

[mathetake]

well, at least I would like you to verify it via QEMU, but no need to add it to the CI I think :D (Closed #581.)

[evacchi]

TBF I tried to setup QEMU and I gave up because it was so slow, but I just realized I could just download a preinstalled image instead of starting from scratch 🤦‍♂️ (probably docker would do too...)

[mathetake]

If setting toolchains locally is something too slow, you could build a binary go test -c -o outputbin on your main machine, and only send the built test binary to the emulated environment. That's how you could avoid the need to install Go, Git, etc

you need test only the platform package around cpuinfo, no need to run full go tests in this repository.

[mathetake]

anyway merging as I think this works!

[mathetake]

#1122

[evacchi]

ok I confirm that it works on a qemu machine started with -cpu qemu64,-sse4_1,-sse4_2; i.e. CompilerSupported() returns false.

[mathetake]

Coolio