Skip to content

Fix fdSeek: result newoffset should be a uint64le #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 10, 2022
Merged

Fix fdSeek: result newoffset should be a uint64le #739

merged 1 commit into from
Aug 10, 2022

Conversation

ncruces
Copy link
Contributor

@ncruces ncruces commented Aug 8, 2022

No description provided.

@ncruces
Copy link
Contributor Author

ncruces commented Aug 9, 2022

Sorry, I had forgotten to git add the test.

@ncruces
Copy link
Contributor Author

ncruces commented Aug 9, 2022

BTW, I need this for dcraw (compiled with zig cc --target=wasm32-wasi), which is a nice filesystem stress test since it does a bunch of ftell/fseeks.

Was working fine with wasmer and wasmtime, with this it works fine on wazero.

codefromthecrypt
codefromthecrypt approved these changes Aug 10, 2022
View reviewed changes
Copy link
Contributor

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great

@codefromthecrypt codefromthecrypt merged commit 00bd58e into tetratelabs:main Aug 10, 2022
@ncruces ncruces mentioned this pull request Aug 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codefromthecrypt codefromthecrypt codefromthecrypt approved these changes

@mathetake mathetake Awaiting requested review from mathetake mathetake is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ncruces @codefromthecrypt